project-base/server-skynet-source-3rd-jemalloc
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify extent_quantize().

Browse Source 
2cdf07aba9 (Fix extent_quantize() to
handle greater-than-huge-size extents.) solved a non-problem; the
expression passed in to index2size() was never too large.  However the
expression could in principle underflow, so fix the actual (latent) bug
and remove unnecessary complexity.
This commit is contained in:
Jason Evans 2016-11-11 22:46:55 -08:00
parent a2af09f025
commit 1aeea0f391
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/extent.c
View File

@ -16,12 +16,9 @@ extent_quantize(size_t size)
assert(size > 0); assert(size > 0);
ind = size2index(size + 1); ind = size2index(size + 1);
if (ind == NSIZES) { if (ind == 0) {
/* /* Avoid underflow. */
* Allocation requests can't directly create extents that exceed return (index2size(0));
* HUGE_MAXCLASS, but extent merging can create them.
*/
return (HUGE_MAXCLASS);
} }
ret = index2size(ind - 1); ret = index2size(ind - 1);
assert(ret <= size); assert(ret <= size);