Bin: Move stats closer to the mutex.

This is a slight cache locality optimization.
This commit is contained in:
David Goldblatt
2021-02-01 12:03:11 -08:00
committed by David Goldblatt
parent c259323ab3
commit 20140629b4
2 changed files with 13 additions and 3 deletions

View File

@@ -347,6 +347,13 @@ tcache_bin_flush_impl(tsd_t *tsd, tcache_t *tcache, cache_bin_t *cache_bin,
cur_bin = arena_get_bin(cur_arena, binind,
cur_binshard);
assert(cur_binshard < bin_infos[binind].n_shards);
/*
* If you're looking at profiles, you might think this
* is a good place to prefetch the bin stats, which are
* often a cache miss. This turns out not to be
* helpful on the workloads we've looked at, with moving
* the bin stats next to the lock seeming to do better.
*/
}
if (small) {