project-base/server-skynet-source-3rd-jemalloc
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hpdata: early bailout for longest free range.

Browse Source 
A number of common special cases allow us to stop iterating through an hpdata's
bitmap earlier rather than later.
This commit is contained in:
David Goldblatt 2021-02-06 11:57:32 -08:00 committed by David Goldblatt
parent d21d5b46b6
commit 271a676dcd
1 changed files with 22 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/hpdata.c
View File

@ -74,6 +74,7 @@ hpdata_reserve_alloc(hpdata_t *hpdata, size_t sz) {
* to serve the allocation. * to serve the allocation.
*/ */
assert(found); assert(found);
assert(len <= hpdata_longest_free_range_get(hpdata));
if (len >= npages) { if (len >= npages) {
/* /*
* We use first-fit within the page slabs; this gives * We use first-fit within the page slabs; this gives
@ -103,12 +104,11 @@ hpdata_reserve_alloc(hpdata_t *hpdata, size_t sz) {
hpdata->h_ntouched += new_dirty; hpdata->h_ntouched += new_dirty;
/* /*
* We might have shrunk the longest free range. We have to keep * If we allocated out of a range that was the longest in the hpdata, it
* scanning until the end of the hpdata to be sure. * might be the only one of that size and we'll have to adjust the
* * metadata.
* TODO: As an optimization, we should only do this when the range we
* just allocated from was equal to the longest free range size.
*/ */
if (len == hpdata_longest_free_range_get(hpdata)) {
start = begin + npages; start = begin + npages;
while (start < HUGEPAGE_PAGES) { while (start < HUGEPAGE_PAGES) {
bool found = fb_urange_iter(hpdata->active_pages, bool found = fb_urange_iter(hpdata->active_pages,
@ -116,12 +116,18 @@ hpdata_reserve_alloc(hpdata_t *hpdata, size_t sz) {
if (!found) { if (!found) {
break; break;
} }
assert(len <= hpdata_longest_free_range_get(hpdata));
if (len == hpdata_longest_free_range_get(hpdata)) {
largest_unchosen_range = len;
break;
}
if (len > largest_unchosen_range) { if (len > largest_unchosen_range) {
largest_unchosen_range = len; largest_unchosen_range = len;
} }
start = begin + len; start = begin + len;
} }
hpdata_longest_free_range_set(hpdata, largest_unchosen_range); hpdata_longest_free_range_set(hpdata, largest_unchosen_range);
}
hpdata_assert_consistent(hpdata); hpdata_assert_consistent(hpdata);
return (void *)( return (void *)(