project-base/server-skynet-source-3rd-jemalloc
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Safety check: Don't directly abort.

Browse Source 
The sized dealloc checks called the generic safety_check_fail, and then called
abort.  This means the failure case isn't mockable, hence not testable.  Fix it
in anticipation of a coming diff.
This commit is contained in:
David Goldblatt 2020-08-03 18:24:05 -07:00 committed by David Goldblatt
parent 60993697d8
commit 53084cc5c2
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/safety_check.c
View File

@ -4,7 +4,6 @@
static void (*safety_check_abort)(const char *message); static void (*safety_check_abort)(const char *message);
void safety_check_fail_sized_dealloc(bool current_dealloc) { void safety_check_fail_sized_dealloc(bool current_dealloc) {
assert(config_opt_safety_checks);
char *src = current_dealloc ? "the current pointer being freed" : char *src = current_dealloc ? "the current pointer being freed" :
"in thread cache, possibly from previous deallocations"; "in thread cache, possibly from previous deallocations";
@ -12,7 +11,6 @@ void safety_check_fail_sized_dealloc(bool current_dealloc) {
" application sized deallocation bugs (source: %s). Suggest building" " application sized deallocation bugs (source: %s). Suggest building"
"with --enable-debug or address sanitizer for debugging. Abort.\n", "with --enable-debug or address sanitizer for debugging. Abort.\n",
src); src);
abort();
} }
void safety_check_set_abort(void (*abort_fn)(const char *)) { void safety_check_set_abort(void (*abort_fn)(const char *)) {