project-base/server-skynet-source-3rd-jemalloc
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use a local variable to set the alignment for this particular allocation

Browse Source 
instead of changing mmap_flags which makes the change permanent. This was
enforcing large alignments for allocations that did not need it causing
fragmentation. Reported by Andreas Gustafsson.
This commit is contained in:
Christos Zoulas 2023-05-31 13:00:35 -04:00 committed by Qi Wang
parent 6d4aa33753
commit 5832ef6589
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/pages.c
View File

@ -155,6 +155,7 @@ os_pages_map(void *addr, size_t size, size_t alignment, bool *commit) {
* of existing mappings, and we only want to create new mappings. * of existing mappings, and we only want to create new mappings.
*/ */
{ {
int flags = mmap_flags;
#ifdef __NetBSD__ #ifdef __NetBSD__
/* /*
* On NetBSD PAGE for a platform is defined to the * On NetBSD PAGE for a platform is defined to the
@ -164,12 +165,12 @@ os_pages_map(void *addr, size_t size, size_t alignment, bool *commit) {
*/ */
if (alignment > os_page || PAGE > os_page) { if (alignment > os_page || PAGE > os_page) {
unsigned int a = ilog2(MAX(alignment, PAGE)); unsigned int a = ilog2(MAX(alignment, PAGE));
mmap_flags |= MAP_ALIGNED(a); flags |= MAP_ALIGNED(a);
} }
#endif #endif
int prot = *commit ? PAGES_PROT_COMMIT : PAGES_PROT_DECOMMIT; int prot = *commit ? PAGES_PROT_COMMIT : PAGES_PROT_DECOMMIT;
ret = mmap(addr, size, prot, mmap_flags, PAGES_FD_TAG, 0); ret = mmap(addr, size, prot, flags, PAGES_FD_TAG, 0);
} }
assert(ret != NULL); assert(ret != NULL);