project-base/server-skynet-source-3rd-jemalloc
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add a hard limit on tcache max size class.

Browse Source 
For locality reasons, tcache bins are integrated in TSD.  Allowing all size
classes to be cached has little benefit, but takes up much thread local storage.
In addition, it complicates the layout which we try hard to optimize.
This commit is contained in:
Qi Wang 2020-10-15 16:37:16 -07:00 committed by Qi Wang
parent 3de19ba401
commit 5e41ff9b74
4 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/jemalloc.xml.in
View File

@ -1314,8 +1314,8 @@ malloc_conf = "xmalloc:true";]]></programlisting>
</term> </term>
<listitem><para>Maximum size class (log base 2) to cache in the <listitem><para>Maximum size class (log base 2) to cache in the
thread-specific cache (tcache). At a minimum, all small size classes thread-specific cache (tcache). At a minimum, all small size classes
are cached, and at a maximum all large size classes are cached. The are cached; and at a maximum, size classes up to 8 MiB can be cached.
default maximum is 32 KiB (2^15).</para></listitem> The default maximum is 32 KiB (2^15).</para></listitem>
</varlistentry> </varlistentry>
<varlistentry id="opt.thp"> <varlistentry id="opt.thp">

2
include/jemalloc/internal/tcache_structs.h
View File

@ -54,7 +54,7 @@ struct tcache_slow_s {
struct tcache_s { struct tcache_s {
tcache_slow_t *tcache_slow; tcache_slow_t *tcache_slow;
cache_bin_t bins[SC_NSIZES]; cache_bin_t bins[TCACHE_NBINS_MAX];
}; };
/* Linkage for list of available (previously used) explicit tcache IDs. */ /* Linkage for list of available (previously used) explicit tcache IDs. */

5
include/jemalloc/internal/tcache_types.h
View File

@ -27,4 +27,9 @@ typedef struct tcaches_s tcaches_t;
/* Used for explicit tcache only. Means flushed but not destroyed. */ /* Used for explicit tcache only. Means flushed but not destroyed. */
#define TCACHES_ELM_NEED_REINIT ((tcache_t *)(uintptr_t)1) #define TCACHES_ELM_NEED_REINIT ((tcache_t *)(uintptr_t)1)
#define TCACHE_LG_MAXCLASS_LIMIT 23 /* tcache_maxclass = 8M */
#define TCACHE_MAXCLASS_LIMIT ((size_t)1 << TCACHE_LG_MAXCLASS_LIMIT)
#define TCACHE_NBINS_MAX (SC_NBINS + SC_NGROUP * \
(TCACHE_LG_MAXCLASS_LIMIT - SC_LG_LARGE_MINCLASS) + 1)
#endif /* JEMALLOC_INTERNAL_TCACHE_TYPES_H */ #endif /* JEMALLOC_INTERNAL_TCACHE_TYPES_H */

12
src/tcache.c
View File

@ -936,20 +936,20 @@ tcache_ncached_max_compute(szind_t szind) {
bool bool
tcache_boot(tsdn_t *tsdn, base_t *base) { tcache_boot(tsdn_t *tsdn, base_t *base) {
/* If necessary, clamp opt_lg_tcache_max. */ /* If necessary, clamp opt_lg_tcache_max. */
if (opt_lg_tcache_max < 0 || (ZU(1) << opt_lg_tcache_max) < tcache_maxclass = opt_lg_tcache_max < 0 ? 0 :
SC_SMALL_MAXCLASS) { ZU(1) << opt_lg_tcache_max;
if (tcache_maxclass < SC_SMALL_MAXCLASS) {
tcache_maxclass = SC_SMALL_MAXCLASS; tcache_maxclass = SC_SMALL_MAXCLASS;
} else { } else if (tcache_maxclass > TCACHE_MAXCLASS_LIMIT) {
tcache_maxclass = (ZU(1) << opt_lg_tcache_max); tcache_maxclass = TCACHE_MAXCLASS_LIMIT;
} }
nhbins = sz_size2index(tcache_maxclass) + 1;
if (malloc_mutex_init(&tcaches_mtx, "tcaches", WITNESS_RANK_TCACHES, if (malloc_mutex_init(&tcaches_mtx, "tcaches", WITNESS_RANK_TCACHES,
malloc_mutex_rank_exclusive)) { malloc_mutex_rank_exclusive)) {
return true; return true;
} }
nhbins = sz_size2index(tcache_maxclass) + 1;
/* Initialize tcache_bin_info. */ /* Initialize tcache_bin_info. */
tcache_bin_info = (cache_bin_info_t *)base_alloc(tsdn, base, tcache_bin_info = (cache_bin_info_t *)base_alloc(tsdn, base,
nhbins * sizeof(cache_bin_info_t), CACHELINE); nhbins * sizeof(cache_bin_info_t), CACHELINE);