project-base/server-skynet-source-3rd-jemalloc
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update base_unmap() to match extent_dalloc_wrapper().

Browse Source 
Reverse the order of forced versus lazy purging attempts in
base_unmap(), in order to match the order in extent_dalloc_wrapper(),
which was reversed by 64e458f5cd
(Implement two-phase decay-based purging.).
This commit is contained in:
Jason Evans 2017-04-16 17:40:16 -07:00
parent 3c9c41edb2
commit 675701660c
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/base.c
View File

@ -31,14 +31,14 @@ static void
base_unmap(extent_hooks_t *extent_hooks, unsigned ind, void *addr, base_unmap(extent_hooks_t *extent_hooks, unsigned ind, void *addr,
size_t size) { size_t size) {
/* /*
* Cascade through dalloc, decommit, purge_lazy, and purge_forced, * Cascade through dalloc, decommit, purge_forced, and purge_lazy,
* stopping at first success. This cascade is performed for consistency * stopping at first success. This cascade is performed for consistency
* with the cascade in extent_dalloc_wrapper() because an application's * with the cascade in extent_dalloc_wrapper() because an application's
* custom hooks may not support e.g. dalloc. This function is only ever * custom hooks may not support e.g. dalloc. This function is only ever
* called as a side effect of arena destruction, so although it might * called as a side effect of arena destruction, so although it might
* seem pointless to do anything besides dalloc here, the application * seem pointless to do anything besides dalloc here, the application
* may in fact want the end state of all associated virtual memory to in * may in fact want the end state of all associated virtual memory to be
* some consistent-but-allocated state. * in some consistent-but-allocated state.
*/ */
if (extent_hooks == &extent_hooks_default) { if (extent_hooks == &extent_hooks_default) {
if (!extent_dalloc_mmap(addr, size)) { if (!extent_dalloc_mmap(addr, size)) {
@ -47,10 +47,10 @@ base_unmap(extent_hooks_t *extent_hooks, unsigned ind, void *addr,
if (!pages_decommit(addr, size)) { if (!pages_decommit(addr, size)) {
return; return;
} }
if (!pages_purge_lazy(addr, size)) { if (!pages_purge_forced(addr, size)) {
return; return;
} }
if (!pages_purge_forced(addr, size)) { if (!pages_purge_lazy(addr, size)) {
return; return;
} }
/* Nothing worked. This should never happen. */ /* Nothing worked. This should never happen. */
@ -66,16 +66,16 @@ base_unmap(extent_hooks_t *extent_hooks, unsigned ind, void *addr,
ind)) { ind)) {
return; return;
} }
if (extent_hooks->purge_lazy != NULL &&
!extent_hooks->purge_lazy(extent_hooks, addr, size, 0, size,
ind)) {
return;
}
if (extent_hooks->purge_forced != NULL && if (extent_hooks->purge_forced != NULL &&
!extent_hooks->purge_forced(extent_hooks, addr, size, 0, !extent_hooks->purge_forced(extent_hooks, addr, size, 0,
size, ind)) { size, ind)) {
return; return;
} }
if (extent_hooks->purge_lazy != NULL &&
!extent_hooks->purge_lazy(extent_hooks, addr, size, 0, size,
ind)) {
return;
}
/* Nothing worked. That's the application's problem. */ /* Nothing worked. That's the application's problem. */
} }
} }