project-base/server-skynet-source-3rd-jemalloc
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify rtree cache replacement policy.

Browse Source 
To avoid memmove on free() fast path, simplify the cache replacement policy to
only bubble up the cache hit element by 1.
This commit is contained in:
Qi Wang 2017-03-27 11:48:39 -07:00 committed by Qi Wang
parent c6d1819e48
commit af3d737a9a
1 changed files with 11 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
include/jemalloc/internal/rtree_inlines.h
View File

@ -325,30 +325,27 @@ rtree_leaf_elm_lookup(tsdn_t *tsdn, rtree_t *rtree, rtree_ctx_t *rtree_ctx,
if (likely(rtree_ctx->cache[i].leafkey == leafkey)) { \ if (likely(rtree_ctx->cache[i].leafkey == leafkey)) { \
rtree_leaf_elm_t *leaf = rtree_ctx->cache[i].leaf; \ rtree_leaf_elm_t *leaf = rtree_ctx->cache[i].leaf; \
if (likely(leaf != NULL)) { \ if (likely(leaf != NULL)) { \
/* Reorder. */ \ /* Bubble up by one. */ \
memmove(&rtree_ctx->cache[1], \ if (i > 0) { \
&rtree_ctx->cache[0], \ rtree_ctx->cache[i] = \
sizeof(rtree_ctx_cache_elm_t) * i); \ rtree_ctx->cache[i - 1]; \
rtree_ctx->cache[0].leafkey = leafkey; \ rtree_ctx->cache[i - 1].leafkey = \
rtree_ctx->cache[0].leaf = leaf; \ leafkey; \
\ rtree_ctx->cache[i - 1].leaf = leaf; \
} \
uintptr_t subkey = rtree_subkey(key, \ uintptr_t subkey = rtree_subkey(key, \
RTREE_HEIGHT-1); \ RTREE_HEIGHT-1); \
return &leaf[subkey]; \ return &leaf[subkey]; \
} \ } \
} \ } \
} while (0) } while (0)
/* Check the MRU cache entry. */ /* Check the first cache entry. */
RTREE_CACHE_CHECK(0); RTREE_CACHE_CHECK(0);
/* /*
* Search the remaining cache elements, and on success move the matching * Search the remaining cache elements, and on success move the matching
* element to the front. Unroll the first iteration to avoid calling * element up by one slot.
* memmove() (the compiler typically optimizes it into raw moves).
*/ */
if (RTREE_CTX_NCACHE > 1) { for (unsigned i = 1; i < RTREE_CTX_NCACHE; i++) {
RTREE_CACHE_CHECK(1);
}
for (unsigned i = 2; i < RTREE_CTX_NCACHE; i++) {
RTREE_CACHE_CHECK(i); RTREE_CACHE_CHECK(i);
} }
#undef RTREE_CACHE_CHECK #undef RTREE_CACHE_CHECK