Remove --disable-tls.
This option is no longer useful, because TLS is correctly configured automatically on all supported platforms. This partially resolves #580.
This commit is contained in:
parent
ae248a2160
commit
b2a8453a3f
5
INSTALL
5
INSTALL
@ -186,11 +186,6 @@ any of the following arguments (not a definitive list) to 'configure':
|
|||||||
practice, this feature usually has little impact on performance unless
|
practice, this feature usually has little impact on performance unless
|
||||||
thread-specific caching is disabled.
|
thread-specific caching is disabled.
|
||||||
|
|
||||||
--disable-tls
|
|
||||||
Disable thread-local storage (TLS), which allows for fast access to
|
|
||||||
thread-local variables via the __thread keyword. If TLS is available,
|
|
||||||
jemalloc uses it for several purposes.
|
|
||||||
|
|
||||||
--disable-cache-oblivious
|
--disable-cache-oblivious
|
||||||
Disable cache-oblivious large allocation alignment for large allocation
|
Disable cache-oblivious large allocation alignment for large allocation
|
||||||
requests with no alignment constraints. If this feature is disabled, all
|
requests with no alignment constraints. If this feature is disabled, all
|
||||||
|
27
configure.ac
27
configure.ac
@ -1670,27 +1670,14 @@ if test "x$enable_lazy_lock" = "x1" ; then
|
|||||||
fi
|
fi
|
||||||
AC_SUBST([enable_lazy_lock])
|
AC_SUBST([enable_lazy_lock])
|
||||||
|
|
||||||
AC_ARG_ENABLE([tls],
|
dnl Automatically configure TLS.
|
||||||
[AS_HELP_STRING([--disable-tls], [Disable thread-local storage (__thread keyword)])],
|
if test "x${force_tls}" = "x1" ; then
|
||||||
if test "x$enable_tls" = "xno" ; then
|
enable_tls="1"
|
||||||
|
elif test "x${force_tls}" = "x0" ; then
|
||||||
enable_tls="0"
|
enable_tls="0"
|
||||||
else
|
else
|
||||||
enable_tls="1"
|
enable_tls="1"
|
||||||
fi
|
fi
|
||||||
,
|
|
||||||
enable_tls=""
|
|
||||||
)
|
|
||||||
if test "x${enable_tls}" = "x" ; then
|
|
||||||
if test "x${force_tls}" = "x1" ; then
|
|
||||||
AC_MSG_RESULT([Forcing TLS to avoid allocator/threading bootstrap issues])
|
|
||||||
enable_tls="1"
|
|
||||||
elif test "x${force_tls}" = "x0" ; then
|
|
||||||
AC_MSG_RESULT([Forcing no TLS to avoid allocator/threading bootstrap issues])
|
|
||||||
enable_tls="0"
|
|
||||||
else
|
|
||||||
enable_tls="1"
|
|
||||||
fi
|
|
||||||
fi
|
|
||||||
if test "x${enable_tls}" = "x1" ; then
|
if test "x${enable_tls}" = "x1" ; then
|
||||||
AC_MSG_CHECKING([for TLS])
|
AC_MSG_CHECKING([for TLS])
|
||||||
AC_COMPILE_IFELSE([AC_LANG_PROGRAM(
|
AC_COMPILE_IFELSE([AC_LANG_PROGRAM(
|
||||||
@ -1709,12 +1696,7 @@ else
|
|||||||
fi
|
fi
|
||||||
AC_SUBST([enable_tls])
|
AC_SUBST([enable_tls])
|
||||||
if test "x${enable_tls}" = "x1" ; then
|
if test "x${enable_tls}" = "x1" ; then
|
||||||
if test "x${force_tls}" = "x0" ; then
|
|
||||||
AC_MSG_WARN([TLS enabled despite being marked unusable on this platform])
|
|
||||||
fi
|
|
||||||
AC_DEFINE_UNQUOTED([JEMALLOC_TLS], [ ])
|
AC_DEFINE_UNQUOTED([JEMALLOC_TLS], [ ])
|
||||||
elif test "x${force_tls}" = "x1" ; then
|
|
||||||
AC_MSG_WARN([TLS disabled despite being marked critical on this platform])
|
|
||||||
fi
|
fi
|
||||||
|
|
||||||
dnl ============================================================================
|
dnl ============================================================================
|
||||||
@ -2170,7 +2152,6 @@ AC_MSG_RESULT([utrace : ${enable_utrace}])
|
|||||||
AC_MSG_RESULT([xmalloc : ${enable_xmalloc}])
|
AC_MSG_RESULT([xmalloc : ${enable_xmalloc}])
|
||||||
AC_MSG_RESULT([munmap : ${enable_munmap}])
|
AC_MSG_RESULT([munmap : ${enable_munmap}])
|
||||||
AC_MSG_RESULT([lazy_lock : ${enable_lazy_lock}])
|
AC_MSG_RESULT([lazy_lock : ${enable_lazy_lock}])
|
||||||
AC_MSG_RESULT([tls : ${enable_tls}])
|
|
||||||
AC_MSG_RESULT([cache-oblivious : ${enable_cache_oblivious}])
|
AC_MSG_RESULT([cache-oblivious : ${enable_cache_oblivious}])
|
||||||
AC_MSG_RESULT([cxx : ${enable_cxx}])
|
AC_MSG_RESULT([cxx : ${enable_cxx}])
|
||||||
AC_MSG_RESULT([===============================================================================])
|
AC_MSG_RESULT([===============================================================================])
|
||||||
|
@ -838,16 +838,6 @@ mallctl("arena." STRINGIFY(MALLCTL_ARENAS_ALL) ".decay",
|
|||||||
build configuration.</para></listitem>
|
build configuration.</para></listitem>
|
||||||
</varlistentry>
|
</varlistentry>
|
||||||
|
|
||||||
<varlistentry id="config.tls">
|
|
||||||
<term>
|
|
||||||
<mallctl>config.tls</mallctl>
|
|
||||||
(<type>bool</type>)
|
|
||||||
<literal>r-</literal>
|
|
||||||
</term>
|
|
||||||
<listitem><para><option>--disable-tls</option> was not specified during
|
|
||||||
build configuration.</para></listitem>
|
|
||||||
</varlistentry>
|
|
||||||
|
|
||||||
<varlistentry id="config.utrace">
|
<varlistentry id="config.utrace">
|
||||||
<term>
|
<term>
|
||||||
<mallctl>config.utrace</mallctl>
|
<mallctl>config.utrace</mallctl>
|
||||||
|
@ -70,7 +70,6 @@ CTL_PROTO(config_prof)
|
|||||||
CTL_PROTO(config_prof_libgcc)
|
CTL_PROTO(config_prof_libgcc)
|
||||||
CTL_PROTO(config_prof_libunwind)
|
CTL_PROTO(config_prof_libunwind)
|
||||||
CTL_PROTO(config_stats)
|
CTL_PROTO(config_stats)
|
||||||
CTL_PROTO(config_tls)
|
|
||||||
CTL_PROTO(config_utrace)
|
CTL_PROTO(config_utrace)
|
||||||
CTL_PROTO(config_xmalloc)
|
CTL_PROTO(config_xmalloc)
|
||||||
CTL_PROTO(opt_abort)
|
CTL_PROTO(opt_abort)
|
||||||
@ -254,7 +253,6 @@ static const ctl_named_node_t config_node[] = {
|
|||||||
{NAME("prof_libgcc"), CTL(config_prof_libgcc)},
|
{NAME("prof_libgcc"), CTL(config_prof_libgcc)},
|
||||||
{NAME("prof_libunwind"), CTL(config_prof_libunwind)},
|
{NAME("prof_libunwind"), CTL(config_prof_libunwind)},
|
||||||
{NAME("stats"), CTL(config_stats)},
|
{NAME("stats"), CTL(config_stats)},
|
||||||
{NAME("tls"), CTL(config_tls)},
|
|
||||||
{NAME("utrace"), CTL(config_utrace)},
|
{NAME("utrace"), CTL(config_utrace)},
|
||||||
{NAME("xmalloc"), CTL(config_xmalloc)}
|
{NAME("xmalloc"), CTL(config_xmalloc)}
|
||||||
};
|
};
|
||||||
@ -1450,7 +1448,6 @@ CTL_RO_CONFIG_GEN(config_prof, bool)
|
|||||||
CTL_RO_CONFIG_GEN(config_prof_libgcc, bool)
|
CTL_RO_CONFIG_GEN(config_prof_libgcc, bool)
|
||||||
CTL_RO_CONFIG_GEN(config_prof_libunwind, bool)
|
CTL_RO_CONFIG_GEN(config_prof_libunwind, bool)
|
||||||
CTL_RO_CONFIG_GEN(config_stats, bool)
|
CTL_RO_CONFIG_GEN(config_stats, bool)
|
||||||
CTL_RO_CONFIG_GEN(config_tls, bool)
|
|
||||||
CTL_RO_CONFIG_GEN(config_utrace, bool)
|
CTL_RO_CONFIG_GEN(config_utrace, bool)
|
||||||
CTL_RO_CONFIG_GEN(config_xmalloc, bool)
|
CTL_RO_CONFIG_GEN(config_xmalloc, bool)
|
||||||
|
|
||||||
|
@ -712,7 +712,6 @@ stats_general_print(void (*write_cb)(void *, const char *), void *cbopaque,
|
|||||||
CONFIG_WRITE_BOOL_JSON(prof_libgcc, ",")
|
CONFIG_WRITE_BOOL_JSON(prof_libgcc, ",")
|
||||||
CONFIG_WRITE_BOOL_JSON(prof_libunwind, ",")
|
CONFIG_WRITE_BOOL_JSON(prof_libunwind, ",")
|
||||||
CONFIG_WRITE_BOOL_JSON(stats, ",")
|
CONFIG_WRITE_BOOL_JSON(stats, ",")
|
||||||
CONFIG_WRITE_BOOL_JSON(tls, ",")
|
|
||||||
CONFIG_WRITE_BOOL_JSON(utrace, ",")
|
CONFIG_WRITE_BOOL_JSON(utrace, ",")
|
||||||
CONFIG_WRITE_BOOL_JSON(xmalloc, "")
|
CONFIG_WRITE_BOOL_JSON(xmalloc, "")
|
||||||
|
|
||||||
|
@ -136,7 +136,6 @@ TEST_BEGIN(test_mallctl_config) {
|
|||||||
TEST_MALLCTL_CONFIG(prof_libgcc, bool);
|
TEST_MALLCTL_CONFIG(prof_libgcc, bool);
|
||||||
TEST_MALLCTL_CONFIG(prof_libunwind, bool);
|
TEST_MALLCTL_CONFIG(prof_libunwind, bool);
|
||||||
TEST_MALLCTL_CONFIG(stats, bool);
|
TEST_MALLCTL_CONFIG(stats, bool);
|
||||||
TEST_MALLCTL_CONFIG(tls, bool);
|
|
||||||
TEST_MALLCTL_CONFIG(utrace, bool);
|
TEST_MALLCTL_CONFIG(utrace, bool);
|
||||||
TEST_MALLCTL_CONFIG(xmalloc, bool);
|
TEST_MALLCTL_CONFIG(xmalloc, bool);
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user