project-base/server-skynet-source-3rd-jemalloc
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix signed/unsigned comparison in arena_lg_dirty_mult_valid().

Browse Source
This commit is contained in:
Jason Evans 2015-03-24 15:59:28 -07:00
parent d324ca8933
commit bd16ea49c3
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/arena.c
View File

@ -1037,7 +1037,8 @@ static bool
arena_lg_dirty_mult_valid(ssize_t lg_dirty_mult) arena_lg_dirty_mult_valid(ssize_t lg_dirty_mult)
{ {
return (lg_dirty_mult >= -1 && lg_dirty_mult < (sizeof(size_t) << 3)); return (lg_dirty_mult >= -1 && lg_dirty_mult < (ssize_t)(sizeof(size_t)
<< 3));
} }
ssize_t ssize_t

6
test/unit/mallctl.c
View File

@ -367,8 +367,8 @@ TEST_BEGIN(test_arena_i_lg_dirty_mult)
"Unexpected mallctl() success"); "Unexpected mallctl() success");
for (prev_lg_dirty_mult = orig_lg_dirty_mult, lg_dirty_mult = -1; for (prev_lg_dirty_mult = orig_lg_dirty_mult, lg_dirty_mult = -1;
lg_dirty_mult < (sizeof(ssize_t) << 3); prev_lg_dirty_mult = lg_dirty_mult < (ssize_t)(sizeof(size_t) << 3); prev_lg_dirty_mult
lg_dirty_mult, lg_dirty_mult++) { = lg_dirty_mult, lg_dirty_mult++) {
ssize_t old_lg_dirty_mult; ssize_t old_lg_dirty_mult;
assert_d_eq(mallctl("arena.0.lg_dirty_mult", &old_lg_dirty_mult, assert_d_eq(mallctl("arena.0.lg_dirty_mult", &old_lg_dirty_mult,
@ -478,7 +478,7 @@ TEST_BEGIN(test_arenas_lg_dirty_mult)
"Unexpected mallctl() success"); "Unexpected mallctl() success");
for (prev_lg_dirty_mult = orig_lg_dirty_mult, lg_dirty_mult = -1; for (prev_lg_dirty_mult = orig_lg_dirty_mult, lg_dirty_mult = -1;
lg_dirty_mult < (sizeof(ssize_t) << 3); prev_lg_dirty_mult = lg_dirty_mult < (ssize_t)(sizeof(size_t) << 3); prev_lg_dirty_mult =
lg_dirty_mult, lg_dirty_mult++) { lg_dirty_mult, lg_dirty_mult++) {
ssize_t old_lg_dirty_mult; ssize_t old_lg_dirty_mult;