project-base/server-skynet-source-3rd-jemalloc
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary zeroing in arena_palloc().

Browse Source
This commit is contained in:
Jason Evans 2013-10-29 18:17:42 -07:00
parent 96eeaec5dd
commit c368f8c8a2
2 changed files with 78 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
include/jemalloc/internal/arena.h
View File

@ -174,11 +174,12 @@ struct arena_chunk_s {
size_t nruns_avail; size_t nruns_avail;
/* /*
* Number of available run adjacencies. Clean and dirty available runs * Number of available run adjacencies that purging could coalesce.
* are not coalesced, which causes virtual memory fragmentation. The * Clean and dirty available runs are not coalesced, which causes
* ratio of (nruns_avail-nruns_adjac):nruns_adjac is used for tracking * virtual memory fragmentation. The ratio of
* this fragmentation. * (nruns_avail-nruns_adjac):nruns_adjac is used for tracking this
* */ * fragmentation.
*/
size_t nruns_adjac; size_t nruns_adjac;
/* /*

72
src/arena.c
View File

@ -46,8 +46,12 @@ static void arena_avail_insert(arena_t *arena, arena_chunk_t *chunk,
static void arena_avail_remove(arena_t *arena, arena_chunk_t *chunk, static void arena_avail_remove(arena_t *arena, arena_chunk_t *chunk,
size_t pageind, size_t npages, bool maybe_adjac_pred, size_t pageind, size_t npages, bool maybe_adjac_pred,
bool maybe_adjac_succ); bool maybe_adjac_succ);
static void arena_run_split_helper(arena_t *arena, arena_run_t *run,
size_t size, bool large, size_t binind, bool remove, bool zero);
static void arena_run_split(arena_t *arena, arena_run_t *run, size_t size, static void arena_run_split(arena_t *arena, arena_run_t *run, size_t size,
bool large, size_t binind, bool zero); bool large, size_t binind, bool zero);
static void arena_run_init(arena_t *arena, arena_run_t *run, size_t size,
bool large, size_t binind, bool zero);
static arena_chunk_t *arena_chunk_alloc(arena_t *arena); static arena_chunk_t *arena_chunk_alloc(arena_t *arena);
static void arena_chunk_dealloc(arena_t *arena, arena_chunk_t *chunk); static void arena_chunk_dealloc(arena_t *arena, arena_chunk_t *chunk);
static arena_run_t *arena_run_alloc_helper(arena_t *arena, size_t size, static arena_run_t *arena_run_alloc_helper(arena_t *arena, size_t size,
@ -388,37 +392,43 @@ arena_run_page_validate_zeroed(arena_chunk_t *chunk, size_t run_ind)
} }
static void static void
arena_run_split(arena_t *arena, arena_run_t *run, size_t size, bool large, arena_run_split_helper(arena_t *arena, arena_run_t *run, size_t size,
size_t binind, bool zero) bool large, size_t binind, bool remove, bool zero)
{ {
arena_chunk_t *chunk; arena_chunk_t *chunk;
size_t run_ind, total_pages, need_pages, rem_pages, i; size_t run_ind, need_pages, i;
size_t flag_dirty; size_t flag_dirty;
assert(large || remove);
assert((large && binind == BININD_INVALID) || (large == false && binind assert((large && binind == BININD_INVALID) || (large == false && binind
!= BININD_INVALID)); != BININD_INVALID));
chunk = (arena_chunk_t *)CHUNK_ADDR2BASE(run); chunk = (arena_chunk_t *)CHUNK_ADDR2BASE(run);
run_ind = (unsigned)(((uintptr_t)run - (uintptr_t)chunk) >> LG_PAGE); run_ind = (unsigned)(((uintptr_t)run - (uintptr_t)chunk) >> LG_PAGE);
flag_dirty = arena_mapbits_dirty_get(chunk, run_ind); flag_dirty = arena_mapbits_dirty_get(chunk, run_ind);
total_pages = arena_mapbits_unallocated_size_get(chunk, run_ind) >>
LG_PAGE;
assert(arena_mapbits_dirty_get(chunk, run_ind+total_pages-1) ==
flag_dirty);
need_pages = (size >> LG_PAGE); need_pages = (size >> LG_PAGE);
assert(need_pages > 0); assert(need_pages > 0);
if (remove) {
size_t total_pages, rem_pages;
total_pages = arena_mapbits_unallocated_size_get(chunk,
run_ind) >> LG_PAGE;
assert(arena_mapbits_dirty_get(chunk, run_ind+total_pages-1) ==
flag_dirty);
assert(need_pages <= total_pages); assert(need_pages <= total_pages);
rem_pages = total_pages - need_pages; rem_pages = total_pages - need_pages;
arena_avail_remove(arena, chunk, run_ind, total_pages, true, true); arena_avail_remove(arena, chunk, run_ind, total_pages, true,
true);
if (config_stats) { if (config_stats) {
/* /*
* Update stats_cactive if nactive is crossing a chunk * Update stats_cactive if nactive is crossing a chunk
* multiple. * multiple.
*/ */
size_t cactive_diff = CHUNK_CEILING((arena->nactive + size_t cactive_diff = CHUNK_CEILING((arena->nactive +
need_pages) << LG_PAGE) - CHUNK_CEILING(arena->nactive << need_pages) << LG_PAGE) -
LG_PAGE); CHUNK_CEILING(arena->nactive << LG_PAGE);
if (cactive_diff != 0) if (cactive_diff != 0)
stats_cactive_add(cactive_diff); stats_cactive_add(cactive_diff);
} }
@ -427,23 +437,25 @@ arena_run_split(arena_t *arena, arena_run_t *run, size_t size, bool large,
/* Keep track of trailing unused pages for later use. */ /* Keep track of trailing unused pages for later use. */
if (rem_pages > 0) { if (rem_pages > 0) {
if (flag_dirty != 0) { if (flag_dirty != 0) {
arena_mapbits_unallocated_set(chunk, run_ind+need_pages,
(rem_pages << LG_PAGE), CHUNK_MAP_DIRTY);
arena_mapbits_unallocated_set(chunk, arena_mapbits_unallocated_set(chunk,
run_ind+total_pages-1, (rem_pages << LG_PAGE), run_ind+need_pages, (rem_pages << LG_PAGE),
CHUNK_MAP_DIRTY); flag_dirty);
arena_mapbits_unallocated_set(chunk,
run_ind+total_pages-1, (rem_pages <<
LG_PAGE), flag_dirty);
} else { } else {
arena_mapbits_unallocated_set(chunk, run_ind+need_pages, arena_mapbits_unallocated_set(chunk,
(rem_pages << LG_PAGE), run_ind+need_pages, (rem_pages << LG_PAGE),
arena_mapbits_unzeroed_get(chunk, arena_mapbits_unzeroed_get(chunk,
run_ind+need_pages)); run_ind+need_pages));
arena_mapbits_unallocated_set(chunk, arena_mapbits_unallocated_set(chunk,
run_ind+total_pages-1, (rem_pages << LG_PAGE), run_ind+total_pages-1, (rem_pages <<
arena_mapbits_unzeroed_get(chunk, LG_PAGE), arena_mapbits_unzeroed_get(chunk,
run_ind+total_pages-1)); run_ind+total_pages-1));
} }
arena_avail_insert(arena, chunk, run_ind+need_pages, rem_pages, arena_avail_insert(arena, chunk, run_ind+need_pages,
false, true); rem_pages, false, true);
}
} }
/* /*
@ -526,6 +538,22 @@ arena_run_split(arena_t *arena, arena_run_t *run, size_t size, bool large,
} }
} }
static void
arena_run_split(arena_t *arena, arena_run_t *run, size_t size, bool large,
size_t binind, bool zero)
{
arena_run_split_helper(arena, run, size, large, binind, true, zero);
}
static void
arena_run_init(arena_t *arena, arena_run_t *run, size_t size, bool large,
size_t binind, bool zero)
{
arena_run_split_helper(arena, run, size, large, binind, false, zero);
}
static arena_chunk_t * static arena_chunk_t *
arena_chunk_alloc(arena_t *arena) arena_chunk_alloc(arena_t *arena)
{ {
@ -1546,7 +1574,7 @@ arena_palloc(arena_t *arena, size_t size, size_t alignment, bool zero)
alloc_size = size + alignment - PAGE; alloc_size = size + alignment - PAGE;
malloc_mutex_lock(&arena->lock); malloc_mutex_lock(&arena->lock);
run = arena_run_alloc(arena, alloc_size, true, BININD_INVALID, zero); run = arena_run_alloc(arena, alloc_size, true, BININD_INVALID, false);
if (run == NULL) { if (run == NULL) {
malloc_mutex_unlock(&arena->lock); malloc_mutex_unlock(&arena->lock);
return (NULL); return (NULL);
@ -1566,6 +1594,8 @@ arena_palloc(arena_t *arena, size_t size, size_t alignment, bool zero)
arena_run_trim_tail(arena, chunk, ret, size + trailsize, size, arena_run_trim_tail(arena, chunk, ret, size + trailsize, size,
false); false);
} }
arena_run_init(arena, (arena_run_t *)ret, size, true, BININD_INVALID,
zero);
if (config_stats) { if (config_stats) {
arena->stats.nmalloc_large++; arena->stats.nmalloc_large++;