project-base/server-skynet-source-3rd-jemalloc
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fast path: allow low-water mark changes.

Browse Source 
This lets us put more allocations on an "almost as fast" path after a flush.
This results in around a 4% reduction in malloc cycles in prod workloads
(corresponding to about a 0.1% reduction in overall cycles).
This commit is contained in:
David Goldblatt
2020-03-04 08:58:42 -08:00
committed by David Goldblatt
parent 397da03865
commit d701a085c2
5 changed files with 86 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
test/unit/cache_bin.c
View File

@@ -17,7 +17,7 @@ do_fill_test(cache_bin_t *bin, cache_bin_info_t *info, void **ptrs,
cache_bin_low_water_set(bin);
for (cache_bin_sz_t i = 0; i < nfill_succeed; i++) {
ptr = cache_bin_alloc_easy(bin, info, &success);
ptr = cache_bin_alloc(bin, &success);
expect_true(success, "");
expect_ptr_eq(ptr, (void *)&ptrs[i],
"Should pop in order filled");
@@ -48,7 +48,7 @@ do_flush_test(cache_bin_t *bin, cache_bin_info_t *info, void **ptrs,
expect_true(cache_bin_ncached_get(bin, info) == nfill - nflush, "");
while (cache_bin_ncached_get(bin, info) > 0) {
cache_bin_alloc_easy(bin, info, &success);
cache_bin_alloc(bin, &success);
}
}
@@ -78,11 +78,11 @@ TEST_BEGIN(test_cache_bin) {
expect_true(cache_bin_ncached_get(&bin, &info) == 0, "");
expect_true(cache_bin_low_water_get(&bin, &info) == 0, "");
ptr = cache_bin_alloc_easy_reduced(&bin, &success);
ptr = cache_bin_alloc_easy(&bin, &success);
expect_false(success, "Shouldn't successfully allocate when empty");
expect_ptr_null(ptr, "Shouldn't get a non-null pointer on failure");
ptr = cache_bin_alloc_easy(&bin, &info, &success);
ptr = cache_bin_alloc(&bin, &success);
expect_false(success, "Shouldn't successfully allocate when empty");
expect_ptr_null(ptr, "Shouldn't get a non-null pointer on failure");
@@ -112,10 +112,10 @@ TEST_BEGIN(test_cache_bin) {
expect_true(cache_bin_ncached_get(&bin, &info)
== ncached_max - i, "");
/*
* This should fail -- the reduced version can't change low
* water.
* This should fail -- the easy variant can't change the low
* water mark.
*/
ptr = cache_bin_alloc_easy_reduced(&bin, &success);
ptr = cache_bin_alloc_easy(&bin, &success);
expect_ptr_null(ptr, "");
expect_false(success, "");
expect_true(cache_bin_low_water_get(&bin, &info)
@@ -124,7 +124,7 @@ TEST_BEGIN(test_cache_bin) {
== ncached_max - i, "");
/* This should succeed, though. */
ptr = cache_bin_alloc_easy(&bin, &info, &success);
ptr = cache_bin_alloc(&bin, &success);
expect_true(success, "");
expect_ptr_eq(ptr, &ptrs[ncached_max - i - 1],
"Alloc should pop in stack order");
@@ -135,10 +135,10 @@ TEST_BEGIN(test_cache_bin) {
}
/* Now we're empty -- all alloc attempts should fail. */
expect_true(cache_bin_ncached_get(&bin, &info) == 0, "");
ptr = cache_bin_alloc_easy_reduced(&bin, &success);
ptr = cache_bin_alloc_easy(&bin, &success);
expect_ptr_null(ptr, "");
expect_false(success, "");
ptr = cache_bin_alloc_easy(&bin, &info, &success);
ptr = cache_bin_alloc(&bin, &success);
expect_ptr_null(ptr, "");
expect_false(success, "");
@@ -156,18 +156,18 @@ TEST_BEGIN(test_cache_bin) {
* Size is bigger than low water -- the reduced version should
* succeed.
*/
ptr = cache_bin_alloc_easy_reduced(&bin, &success);
ptr = cache_bin_alloc_easy(&bin, &success);
expect_true(success, "");
expect_ptr_eq(ptr, &ptrs[i], "");
}
/* But now, we've hit low-water. */
ptr = cache_bin_alloc_easy_reduced(&bin, &success);
ptr = cache_bin_alloc_easy(&bin, &success);
expect_false(success, "");
expect_ptr_null(ptr, "");
/* We're going to test filling -- we must be empty to start. */
while (cache_bin_ncached_get(&bin, &info)) {
cache_bin_alloc_easy(&bin, &info, &success);
cache_bin_alloc(&bin, &success);
expect_true(success, "");
}