From de49674fbde4d124a0a7e7e97f5656e190980759 Mon Sep 17 00:00:00 2001
From: Jason Evans <jasone@canonware.com>
Date: Tue, 21 Feb 2017 23:40:06 -0800
Subject: [PATCH] Use MALLOC_CONF rather than malloc_conf for tests.

malloc_conf does not reliably work with MSVC, which complains of
"inconsistent dll linkage", i.e. its inability to support the
application overriding malloc_conf when dynamically linking/loading.
Work around this limitation by adding test harness support for per test
shell script sourcing, and converting all tests to use MALLOC_CONF
instead of malloc_conf.
---
 test/integration/extent.c     |  4 ----
 test/integration/extent.sh    |  5 +++++
 test/integration/mallocx.c    |  4 ----
 test/integration/mallocx.sh   |  5 +++++
 test/integration/xallocx.c    |  4 ----
 test/integration/xallocx.sh   |  5 +++++
 test/test.sh.in               | 29 ++++++++++++++++++++++++++++-
 test/unit/arena_reset_prof.c  |  1 -
 test/unit/arena_reset_prof.sh |  3 +++
 test/unit/decay.c             |  6 ------
 test/unit/decay.sh            |  6 ++++++
 test/unit/junk.c              |  8 --------
 test/unit/junk.sh             |  5 +++++
 test/unit/junk_alloc.c        |  2 --
 test/unit/junk_alloc.sh       |  5 +++++
 test/unit/junk_free.c         |  2 --
 test/unit/junk_free.sh        |  5 +++++
 test/unit/pack.c              |  3 ---
 test/unit/pack.sh             |  4 ++++
 test/unit/prof_accum.c        |  5 -----
 test/unit/prof_accum.sh       |  5 +++++
 test/unit/prof_active.c       |  5 -----
 test/unit/prof_active.sh      |  5 +++++
 test/unit/prof_gdump.c        |  4 ----
 test/unit/prof_gdump.sh       |  6 ++++++
 test/unit/prof_idump.c        | 13 -------------
 test/unit/prof_idump.sh       | 12 ++++++++++++
 test/unit/prof_reset.c        |  5 -----
 test/unit/prof_reset.sh       |  5 +++++
 test/unit/prof_tctx.c         |  4 ----
 test/unit/prof_tctx.sh        |  5 +++++
 test/unit/prof_thread_name.c  |  4 ----
 test/unit/prof_thread_name.sh |  5 +++++
 test/unit/zero.c              |  5 -----
 test/unit/zero.sh             |  5 +++++
 35 files changed, 119 insertions(+), 80 deletions(-)
 create mode 100644 test/integration/extent.sh
 create mode 100644 test/integration/mallocx.sh
 create mode 100644 test/integration/xallocx.sh
 create mode 100644 test/unit/arena_reset_prof.sh
 create mode 100644 test/unit/decay.sh
 create mode 100644 test/unit/junk.sh
 create mode 100644 test/unit/junk_alloc.sh
 create mode 100644 test/unit/junk_free.sh
 create mode 100644 test/unit/pack.sh
 create mode 100644 test/unit/prof_accum.sh
 create mode 100644 test/unit/prof_active.sh
 create mode 100644 test/unit/prof_gdump.sh
 create mode 100644 test/unit/prof_idump.sh
 create mode 100644 test/unit/prof_reset.sh
 create mode 100644 test/unit/prof_tctx.sh
 create mode 100644 test/unit/prof_thread_name.sh
 create mode 100644 test/unit/zero.sh

diff --git a/test/integration/extent.c b/test/integration/extent.c
index 08792df3..32432af9 100644
--- a/test/integration/extent.c
+++ b/test/integration/extent.c
@@ -1,9 +1,5 @@
 #include "test/jemalloc_test.h"
 
-#ifdef JEMALLOC_FILL
-const char *malloc_conf = "junk:false";
-#endif
-
 #include "test/extent_hooks.h"
 
 static void
diff --git a/test/integration/extent.sh b/test/integration/extent.sh
new file mode 100644
index 00000000..0cc21873
--- /dev/null
+++ b/test/integration/extent.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ "x${enable_fill}" = "x1" ] ; then
+  export MALLOC_CONF="junk:false"
+fi
diff --git a/test/integration/mallocx.c b/test/integration/mallocx.c
index b60e27b6..b0b5cdac 100644
--- a/test/integration/mallocx.c
+++ b/test/integration/mallocx.c
@@ -1,9 +1,5 @@
 #include "test/jemalloc_test.h"
 
-#ifdef JEMALLOC_FILL
-const char *malloc_conf = "junk:false";
-#endif
-
 static unsigned
 get_nsizes_impl(const char *cmd) {
 	unsigned ret;
diff --git a/test/integration/mallocx.sh b/test/integration/mallocx.sh
new file mode 100644
index 00000000..0cc21873
--- /dev/null
+++ b/test/integration/mallocx.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ "x${enable_fill}" = "x1" ] ; then
+  export MALLOC_CONF="junk:false"
+fi
diff --git a/test/integration/xallocx.c b/test/integration/xallocx.c
index c95fbf18..cd0ca048 100644
--- a/test/integration/xallocx.c
+++ b/test/integration/xallocx.c
@@ -1,9 +1,5 @@
 #include "test/jemalloc_test.h"
 
-#ifdef JEMALLOC_FILL
-const char *malloc_conf = "junk:false";
-#endif
-
 /*
  * Use a separate arena for xallocx() extension/contraction tests so that
  * internal allocation e.g. by heap profiling can't interpose allocations where
diff --git a/test/integration/xallocx.sh b/test/integration/xallocx.sh
new file mode 100644
index 00000000..0cc21873
--- /dev/null
+++ b/test/integration/xallocx.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ "x${enable_fill}" = "x1" ] ; then
+  export MALLOC_CONF="junk:false"
+fi
diff --git a/test/test.sh.in b/test/test.sh.in
index a39f99f6..f0f0f979 100644
--- a/test/test.sh.in
+++ b/test/test.sh.in
@@ -11,6 +11,18 @@ case @abi@ in
     ;;
 esac
 
+# Make a copy of the @JEMALLOC_CPREFIX@MALLOC_CONF passed in to this script, so
+# it can be repeatedly concatenated with per test settings.
+export MALLOC_CONF_ALL=${@JEMALLOC_CPREFIX@MALLOC_CONF}
+# Concatenate the individual test's MALLOC_CONF and MALLOC_CONF_ALL.
+export_malloc_conf() {
+  if [ "x${MALLOC_CONF}" != "x" -a "x${MALLOC_CONF_ALL}" != "x" ] ; then
+    export @JEMALLOC_CPREFIX@MALLOC_CONF="${MALLOC_CONF},${MALLOC_CONF_ALL}"
+  else
+    export @JEMALLOC_CPREFIX@MALLOC_CONF="${MALLOC_CONF}${MALLOC_CONF_ALL}"
+  fi
+}
+
 # Corresponds to test_status_t.
 pass_code=0
 skip_code=1
@@ -24,7 +36,22 @@ for t in $@; do
     echo
   fi
   echo "=== ${t} ==="
-  ${t}@exe@ @abs_srcroot@ @abs_objroot@
+  if [ -e "@srcroot@${t}.sh" ] ; then
+    # Source the shell script corresponding to the test in a subshell and
+    # execute the test.  This allows the shell script to set MALLOC_CONF, which
+    # is then used to set @JEMALLOC_CPREFIX@MALLOC_CONF (thus allowing the
+    # per test shell script to ignore the @JEMALLOC_CPREFIX@ detail).
+    $(enable_fill=@enable_fill@ \
+      enable_prof=@enable_prof@ \
+      enable_tcache=@enable_tcache@ \
+      . @srcroot@${t}.sh && \
+      export_malloc_conf && \
+      ${t}@exe@ @abs_srcroot@ @abs_objroot@)
+  else
+    $(export MALLOC_CONF= && \
+      export_malloc_conf &&
+      ${t}@exe@ @abs_srcroot@ @abs_objroot@)
+  fi
   result_code=$?
   case ${result_code} in
     ${pass_code})
diff --git a/test/unit/arena_reset_prof.c b/test/unit/arena_reset_prof.c
index 6d83c843..38d80124 100644
--- a/test/unit/arena_reset_prof.c
+++ b/test/unit/arena_reset_prof.c
@@ -1,5 +1,4 @@
 #include "test/jemalloc_test.h"
 #define ARENA_RESET_PROF_C_
 
-const char *malloc_conf = "prof:true,lg_prof_sample:0";
 #include "arena_reset.c"
diff --git a/test/unit/arena_reset_prof.sh b/test/unit/arena_reset_prof.sh
new file mode 100644
index 00000000..041dc1c3
--- /dev/null
+++ b/test/unit/arena_reset_prof.sh
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+export MALLOC_CONF="prof:true,lg_prof_sample:0"
diff --git a/test/unit/decay.c b/test/unit/decay.c
index fc8fabcf..98453221 100644
--- a/test/unit/decay.c
+++ b/test/unit/decay.c
@@ -1,11 +1,5 @@
 #include "test/jemalloc_test.h"
 
-const char *malloc_conf = "decay_time:1"
-#ifdef JEMALLOC_TCACHE
-    ",lg_tcache_max:0"
-#endif
-    ;
-
 static nstime_monotonic_t *nstime_monotonic_orig;
 static nstime_update_t *nstime_update_orig;
 
diff --git a/test/unit/decay.sh b/test/unit/decay.sh
new file mode 100644
index 00000000..284af815
--- /dev/null
+++ b/test/unit/decay.sh
@@ -0,0 +1,6 @@
+#!/bin/sh
+
+export MALLOC_CONF="decay_time:1"
+if [ "x${enable_tcache}" = "x1" ] ; then
+  export MALLOC_CONF="${MALLOC_CONF},lg_tcache_max:0"
+fi
diff --git a/test/unit/junk.c b/test/unit/junk.c
index 86c51089..cfa8d0f2 100644
--- a/test/unit/junk.c
+++ b/test/unit/junk.c
@@ -1,13 +1,5 @@
 #include "test/jemalloc_test.h"
 
-#ifdef JEMALLOC_FILL
-#  ifndef JEMALLOC_TEST_JUNK_OPT
-#    define JEMALLOC_TEST_JUNK_OPT "junk:true"
-#  endif
-const char *malloc_conf =
-    "abort:false,zero:false," JEMALLOC_TEST_JUNK_OPT;
-#endif
-
 static arena_dalloc_junk_small_t *arena_dalloc_junk_small_orig;
 static large_dalloc_junk_t *large_dalloc_junk_orig;
 static large_dalloc_maybe_junk_t *large_dalloc_maybe_junk_orig;
diff --git a/test/unit/junk.sh b/test/unit/junk.sh
new file mode 100644
index 00000000..97cd8ca5
--- /dev/null
+++ b/test/unit/junk.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ "x${enable_fill}" = "x1" ] ; then
+  export MALLOC_CONF="abort:false,zero:false,junk:true"
+fi
diff --git a/test/unit/junk_alloc.c b/test/unit/junk_alloc.c
index 8db3331d..a442a0ca 100644
--- a/test/unit/junk_alloc.c
+++ b/test/unit/junk_alloc.c
@@ -1,3 +1 @@
-#define JEMALLOC_TEST_JUNK_OPT "junk:alloc"
 #include "junk.c"
-#undef JEMALLOC_TEST_JUNK_OPT
diff --git a/test/unit/junk_alloc.sh b/test/unit/junk_alloc.sh
new file mode 100644
index 00000000..e1008c2e
--- /dev/null
+++ b/test/unit/junk_alloc.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ "x${enable_fill}" = "x1" ] ; then
+  export MALLOC_CONF="abort:false,zero:false,junk:alloc"
+fi
diff --git a/test/unit/junk_free.c b/test/unit/junk_free.c
index 482a61d0..a442a0ca 100644
--- a/test/unit/junk_free.c
+++ b/test/unit/junk_free.c
@@ -1,3 +1 @@
-#define JEMALLOC_TEST_JUNK_OPT "junk:free"
 #include "junk.c"
-#undef JEMALLOC_TEST_JUNK_OPT
diff --git a/test/unit/junk_free.sh b/test/unit/junk_free.sh
new file mode 100644
index 00000000..402196ca
--- /dev/null
+++ b/test/unit/junk_free.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ "x${enable_fill}" = "x1" ] ; then
+  export MALLOC_CONF="abort:false,zero:false,junk:free"
+fi
diff --git a/test/unit/pack.c b/test/unit/pack.c
index d35ac5ea..5da4ae12 100644
--- a/test/unit/pack.c
+++ b/test/unit/pack.c
@@ -1,8 +1,5 @@
 #include "test/jemalloc_test.h"
 
-/* Immediately purge to minimize fragmentation. */
-const char *malloc_conf = "decay_time:-1";
-
 /*
  * Size class that is a divisor of the page size, ideally 4+ regions per run.
  */
diff --git a/test/unit/pack.sh b/test/unit/pack.sh
new file mode 100644
index 00000000..de12e553
--- /dev/null
+++ b/test/unit/pack.sh
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+# Immediately purge to minimize fragmentation.
+export MALLOC_CONF="decay_time:-1"
diff --git a/test/unit/prof_accum.c b/test/unit/prof_accum.c
index bcd1d881..6ccab82b 100644
--- a/test/unit/prof_accum.c
+++ b/test/unit/prof_accum.c
@@ -5,11 +5,6 @@
 #define DUMP_INTERVAL		1
 #define BT_COUNT_CHECK_INTERVAL	5
 
-#ifdef JEMALLOC_PROF
-const char *malloc_conf =
-    "prof:true,prof_accum:true,prof_active:false,lg_prof_sample:0";
-#endif
-
 static int
 prof_dump_open_intercept(bool propagate_err, const char *filename) {
 	int fd;
diff --git a/test/unit/prof_accum.sh b/test/unit/prof_accum.sh
new file mode 100644
index 00000000..b3e13fc5
--- /dev/null
+++ b/test/unit/prof_accum.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ "x${enable_prof}" = "x1" ] ; then
+  export MALLOC_CONF="prof:true,prof_accum:true,prof_active:false,lg_prof_sample:0"
+fi
diff --git a/test/unit/prof_active.c b/test/unit/prof_active.c
index c0e085a8..275aac89 100644
--- a/test/unit/prof_active.c
+++ b/test/unit/prof_active.c
@@ -1,10 +1,5 @@
 #include "test/jemalloc_test.h"
 
-#ifdef JEMALLOC_PROF
-const char *malloc_conf =
-    "prof:true,prof_thread_active_init:false,lg_prof_sample:0";
-#endif
-
 static void
 mallctl_bool_get(const char *name, bool expected, const char *func, int line) {
 	bool old;
diff --git a/test/unit/prof_active.sh b/test/unit/prof_active.sh
new file mode 100644
index 00000000..0167cb10
--- /dev/null
+++ b/test/unit/prof_active.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ "x${enable_prof}" = "x1" ] ; then
+  export MALLOC_CONF="prof:true,prof_thread_active_init:false,lg_prof_sample:0"
+fi
diff --git a/test/unit/prof_gdump.c b/test/unit/prof_gdump.c
index 30320b7a..97ade68c 100644
--- a/test/unit/prof_gdump.c
+++ b/test/unit/prof_gdump.c
@@ -1,9 +1,5 @@
 #include "test/jemalloc_test.h"
 
-#ifdef JEMALLOC_PROF
-const char *malloc_conf = "prof:true,prof_active:false,prof_gdump:true";
-#endif
-
 static bool did_prof_dump_open;
 
 static int
diff --git a/test/unit/prof_gdump.sh b/test/unit/prof_gdump.sh
new file mode 100644
index 00000000..3f600d20
--- /dev/null
+++ b/test/unit/prof_gdump.sh
@@ -0,0 +1,6 @@
+#!/bin/sh
+
+if [ "x${enable_prof}" = "x1" ] ; then
+  export MALLOC_CONF="prof:true,prof_active:false,prof_gdump:true"
+fi
+
diff --git a/test/unit/prof_idump.c b/test/unit/prof_idump.c
index 1fed7b37..1cc6c98c 100644
--- a/test/unit/prof_idump.c
+++ b/test/unit/prof_idump.c
@@ -1,18 +1,5 @@
 #include "test/jemalloc_test.h"
 
-const char *malloc_conf = ""
-#ifdef JEMALLOC_PROF
-    "prof:true,prof_accum:true,prof_active:false,lg_prof_sample:0"
-    ",lg_prof_interval:0"
-#  ifdef JEMALLOC_TCACHE
-    ","
-#  endif
-#endif
-#ifdef JEMALLOC_TCACHE
-    "tcache:false"
-#endif
-    ;
-
 static bool did_prof_dump_open;
 
 static int
diff --git a/test/unit/prof_idump.sh b/test/unit/prof_idump.sh
new file mode 100644
index 00000000..fdb5813f
--- /dev/null
+++ b/test/unit/prof_idump.sh
@@ -0,0 +1,12 @@
+#!/bin/sh
+
+if [ "x${enable_prof}" = "x1" ] ; then
+  export MALLOC_CONF="prof:true,prof_accum:true,prof_active:false,lg_prof_sample:0,lg_prof_interval:0"
+  if [ "x${enable_tcache}" = "x1" ] ; then
+    export MALLOC_CONF="${MALLOC_CONF},tcache:false"
+  fi
+elif [ "x${enable_tcache}" = "x1" ] ; then
+  export MALLOC_CONF="tcache:false"
+fi
+
+
diff --git a/test/unit/prof_reset.c b/test/unit/prof_reset.c
index fc954f9f..6120714e 100644
--- a/test/unit/prof_reset.c
+++ b/test/unit/prof_reset.c
@@ -1,10 +1,5 @@
 #include "test/jemalloc_test.h"
 
-#ifdef JEMALLOC_PROF
-const char *malloc_conf =
-    "prof:true,prof_active:false,lg_prof_sample:0";
-#endif
-
 static int
 prof_dump_open_intercept(bool propagate_err, const char *filename) {
 	int fd;
diff --git a/test/unit/prof_reset.sh b/test/unit/prof_reset.sh
new file mode 100644
index 00000000..43c516a0
--- /dev/null
+++ b/test/unit/prof_reset.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ "x${enable_prof}" = "x1" ] ; then
+  export MALLOC_CONF="prof:true,prof_active:false,lg_prof_sample:0"
+fi
diff --git a/test/unit/prof_tctx.c b/test/unit/prof_tctx.c
index 2e35b7ec..14510c65 100644
--- a/test/unit/prof_tctx.c
+++ b/test/unit/prof_tctx.c
@@ -1,9 +1,5 @@
 #include "test/jemalloc_test.h"
 
-#ifdef JEMALLOC_PROF
-const char *malloc_conf = "prof:true,lg_prof_sample:0";
-#endif
-
 TEST_BEGIN(test_prof_realloc) {
 	tsdn_t *tsdn;
 	int flags;
diff --git a/test/unit/prof_tctx.sh b/test/unit/prof_tctx.sh
new file mode 100644
index 00000000..8fcc7d8a
--- /dev/null
+++ b/test/unit/prof_tctx.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ "x${enable_prof}" = "x1" ] ; then
+  export MALLOC_CONF="prof:true,lg_prof_sample:0"
+fi
diff --git a/test/unit/prof_thread_name.c b/test/unit/prof_thread_name.c
index a094a1c0..c9c2a2b7 100644
--- a/test/unit/prof_thread_name.c
+++ b/test/unit/prof_thread_name.c
@@ -1,9 +1,5 @@
 #include "test/jemalloc_test.h"
 
-#ifdef JEMALLOC_PROF
-const char *malloc_conf = "prof:true,prof_active:false";
-#endif
-
 static void
 mallctl_thread_name_get_impl(const char *thread_name_expected, const char *func,
     int line) {
diff --git a/test/unit/prof_thread_name.sh b/test/unit/prof_thread_name.sh
new file mode 100644
index 00000000..298c1058
--- /dev/null
+++ b/test/unit/prof_thread_name.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ "x${enable_prof}" = "x1" ] ; then
+  export MALLOC_CONF="prof:true,prof_active:false"
+fi
diff --git a/test/unit/zero.c b/test/unit/zero.c
index d5b03f8d..553692ba 100644
--- a/test/unit/zero.c
+++ b/test/unit/zero.c
@@ -1,10 +1,5 @@
 #include "test/jemalloc_test.h"
 
-#ifdef JEMALLOC_FILL
-const char *malloc_conf =
-    "abort:false,junk:false,zero:true";
-#endif
-
 static void
 test_zero(size_t sz_min, size_t sz_max) {
 	uint8_t *s;
diff --git a/test/unit/zero.sh b/test/unit/zero.sh
new file mode 100644
index 00000000..b4540b27
--- /dev/null
+++ b/test/unit/zero.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ "x${enable_fill}" = "x1" ] ; then
+  export MALLOC_CONF="abort:false,junk:false,zero:true"
+fi