8 Commits

Author	SHA1	Message	Date
Kevin Svetlitski	70344a2d38	Make eligible functions static ... The codebase is already very disciplined in making any function which can be `static`, but there are a few that appear to have slipped through the cracks.	2023-05-08 15:00:02 -07:00
David Goldblatt	734e72ce8f	bit_util: Guarantee popcount's presence. ... Implement popcount generically, so that we can rely on it being present.	2020-12-07 06:21:08 -08:00
David Goldblatt	22da836094	bit_util: Add fls_ functions; "find last set". ... These simplify a lot of the bit_util module, which had grown bits and pieces of this functionality across a variety of places over the years. While we're here, kill off BIT_UTIL_INLINE and don't do reentrancy testing for bit_util.	2020-07-30 15:25:23 -07:00
David Goldblatt	1ed0288d9c	bit_util: Change ffs functions indexing. ... Making these 0-based instead of 1-based makes calling code simpler and will be more consistent with functions introduced in subsequent diffs.	2020-07-30 15:25:23 -07:00
Yinan Zhang	21dfa4300d	Change assert_* to expect_* in tests ... ``` grep -Irl assert_ test/ | xargs sed -i \ 's/witness_assert/witness_do_not_replace/g'; grep -Irl assert_ test/ | xargs sed -i \ 's/malloc_mutex_assert_owner/malloc_mutex_do_not_replace_owner/g'; grep -Ir assert_ test/ | grep -o "[_a-zA-Z]*assert_[_a-zA-Z]*" | \ grep -v "^assert_"; # confirm no output grep -Irl assert_ test/ | xargs sed -i 's/assert_/expect_/g'; grep -Irl witness_do_not_replace test/ | xargs sed -i \ 's/witness_do_not_replace/witness_assert/g'; grep -Irl malloc_mutex_do_not_replace_owner test/ | xargs sed -i \ 's/malloc_mutex_do_not_replace_owner/malloc_mutex_assert_owner/g'; ```	2020-02-19 16:03:16 -08:00
David Goldblatt	2f07e92adb	Add lg_ceil to bit_util. ... Also, add the bit_util test back to the Makefile.	2018-07-12 20:53:06 -07:00
David Goldblatt	0b00ffe55f	Header refactoring: move bit_util.h out of the catchall	2017-04-18 18:35:03 -07:00
David Goldblatt	e9852b5776	Disentangle assert and util ... This is the first header refactoring diff, #533. It splits the assert and util components into separate, hermetic, header files. In the process, it splits out two of the large sub-components of util (the stdio.h replacement, and bit manipulation routines) into their own components (malloc_io.h and bit_util.h). This is mostly to break up cyclic dependencies, but it also breaks off a good chunk of the catch-all-ness of util, which is nice.	2017-03-06 15:08:43 -08:00