3d29d11ac2
Before this commit jemalloc produced many warnings when compiled with -Wextra
with both Clang and GCC. This commit fixes the issues raised by these warnings
or suppresses them if they were spurious at least for the Clang and GCC
versions covered by CI.
This commit:
* adds `JEMALLOC_DIAGNOSTIC` macros: `JEMALLOC_DIAGNOSTIC_{PUSH,POP}` are
used to modify the stack of enabled diagnostics. The
`JEMALLOC_DIAGNOSTIC_IGNORE_...` macros are used to ignore a concrete
diagnostic.
* adds `JEMALLOC_FALLTHROUGH` macro to explicitly state that falling
through `case` labels in a `switch` statement is intended
* Removes all UNUSED annotations on function parameters. The warning
-Wunused-parameter is now disabled globally in
`jemalloc_internal_macros.h` for all translation units that include
that header. It is never re-enabled since that header cannot be
included by users.
* locally suppresses some -Wextra diagnostics:
* `-Wmissing-field-initializer` is buggy in older Clang and GCC versions,
where it does not understanding that, in C, `= {0}` is a common C idiom
to initialize a struct to zero
* `-Wtype-bounds` is suppressed in a particular situation where a generic
macro, used in multiple different places, compares an unsigned integer for
smaller than zero, which is always true.
* `-Walloc-larger-than-size=` diagnostics warn when an allocation function is
called with a size that is too large (out-of-range). These are suppressed in
the parts of the tests where `jemalloc` explicitly does this to test that the
allocation functions fail properly.
* adds a new CI build bot that runs the log unit test on CI.
Closes #1196 .
51 lines
1.8 KiB
C
51 lines
1.8 KiB
C
#ifndef JEMALLOC_INTERNAL_RTREE_CTX_H
|
|
#define JEMALLOC_INTERNAL_RTREE_CTX_H
|
|
|
|
/*
|
|
* Number of leafkey/leaf pairs to cache in L1 and L2 level respectively. Each
|
|
* entry supports an entire leaf, so the cache hit rate is typically high even
|
|
* with a small number of entries. In rare cases extent activity will straddle
|
|
* the boundary between two leaf nodes. Furthermore, an arena may use a
|
|
* combination of dss and mmap. Note that as memory usage grows past the amount
|
|
* that this cache can directly cover, the cache will become less effective if
|
|
* locality of reference is low, but the consequence is merely cache misses
|
|
* while traversing the tree nodes.
|
|
*
|
|
* The L1 direct mapped cache offers consistent and low cost on cache hit.
|
|
* However collision could affect hit rate negatively. This is resolved by
|
|
* combining with a L2 LRU cache, which requires linear search and re-ordering
|
|
* on access but suffers no collision. Note that, the cache will itself suffer
|
|
* cache misses if made overly large, plus the cost of linear search in the LRU
|
|
* cache.
|
|
*/
|
|
#define RTREE_CTX_LG_NCACHE 4
|
|
#define RTREE_CTX_NCACHE (1 << RTREE_CTX_LG_NCACHE)
|
|
#define RTREE_CTX_NCACHE_L2 8
|
|
|
|
/*
|
|
* Zero initializer required for tsd initialization only. Proper initialization
|
|
* done via rtree_ctx_data_init().
|
|
*/
|
|
#define RTREE_CTX_ZERO_INITIALIZER {{{0, 0}}, {{0, 0}}}
|
|
|
|
|
|
typedef struct rtree_leaf_elm_s rtree_leaf_elm_t;
|
|
|
|
typedef struct rtree_ctx_cache_elm_s rtree_ctx_cache_elm_t;
|
|
struct rtree_ctx_cache_elm_s {
|
|
uintptr_t leafkey;
|
|
rtree_leaf_elm_t *leaf;
|
|
};
|
|
|
|
typedef struct rtree_ctx_s rtree_ctx_t;
|
|
struct rtree_ctx_s {
|
|
/* Direct mapped cache. */
|
|
rtree_ctx_cache_elm_t cache[RTREE_CTX_NCACHE];
|
|
/* L2 LRU cache. */
|
|
rtree_ctx_cache_elm_t l2_cache[RTREE_CTX_NCACHE_L2];
|
|
};
|
|
|
|
void rtree_ctx_data_init(rtree_ctx_t *ctx);
|
|
|
|
#endif /* JEMALLOC_INTERNAL_RTREE_CTX_H */
|